Skip to content

fix: own module verification process groups through cleanup - #111

Merged
rldyourmnd merged 2 commits into
mainfrom
fix/module-process-ownership-20260908
Sep 8, 2026
Merged

fix: own module verification process groups through cleanup#111
rldyourmnd merged 2 commits into
mainfrom
fix/module-process-ownership-20260908

Conversation

@rldyourmnd

Copy link
Copy Markdown
Contributor

Summary

  • Own each declared module command in a new process group, TERM then KILL, and wait until Linux proc or the macOS group is no longer executing.
  • Preserve the throwaway checkout and skip later lanes when cleanup is not proven; failed RemoveWorktree cannot report a clean workspace.
  • Unsupported OS fails closed instead of inheriting the caller's process group.

Test plan

  • go test ./core/app on Linux: descendant timeout, pipeline cancel, background writer, failed worktree remove, unsupported-OS source contract
  • Native macOS process-group / zombie observation was not executed on this Linux workstation

rldyourmnd and others added 2 commits September 8, 2026 11:52
Setpgid plus TERM/KILL with a bounded wait, preserve the checkout when
cleanup is not proven, and skip later lanes so a leftover writer cannot
be reported as a passing verification.

Signed-off-by: rldyourmnd <danil@nddev.it.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ship

core/app is inside the development source boundary, so the process-group
fix invalidates the applied source_tree_digest until the lock is regenerated.

Signed-off-by: rldyourmnd <danil@nddev.it.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@rldyourmnd

Copy link
Copy Markdown
Contributor Author

Self-review: process-group ownership is the intended R05 fix (Setpgid, TERM→KILL, preserve checkout on CleanupPending). CI red was GDS_CONTEXT_POLICY_SOURCE_DIGEST_MISMATCH because core/app is in the development source boundary. Regenerated the development lock and gds-ci.yml from this tree. Not runtime-verified on macOS native.

@rldyourmnd
rldyourmnd merged commit 80125a6 into main Sep 8, 2026
5 checks passed
@rldyourmnd
rldyourmnd deleted the fix/module-process-ownership-20260908 branch September 8, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant