fix(security): preserve required check names in private-free migration - #98
Merged
Merged
Conversation
Signed-off-by: rldyourmnd <danil@nddev.it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A caller migrating from the SARIF security bundle to the private-free variant can retain a required check context without changing repository protection. Add optional
check_name; its default preserves the existing private-free display name. The caller may select the legacy inner name while all four scanners, aggregate failure and one-day artifact evidence remain unchanged.Update the capability description, migration guidance and example. No paid feature or code-scanning upload is introduced.
Type of change
Threat-model note
The input is used only in
jobs.security-bundle.name, never in shell commands, paths, API requests or permissions. The caller controls its display identity through reviewed workflow configuration. A semantic YAML comparison confirmed that the sole workflow changes are the optional input and job display name; every scanner and artifact step remains identical.Permissions diff
No change: workflow
permissions: {}, jobcontents: read. The private-free variant requires noactions: readorsecurity-events: writescope.Validation
validate_all.pycore/touched/scheduled checks passed through the isolated Python launcher.This is source/contract verification. A consumer run must still confirm its chosen final check context.
Tier impact