skills: tighten the review draft before it is posted - #16
Open
oksuzian wants to merge 1 commit into
Open
Conversation
Both review skills state that length is not thoroughness, but neither had a step where that rule fires. It did not fire on Offline#1933: the review shipped a full three-part Evidence/Impact/Suggested-fix block on a S3 nit and a residual-risk bullet caveating a hand analysis that duplicated a check CI had already run and passed. Add a tightening pass to reviewing-pull-requests, run after findings are recorded and before the publish gates, and reference it from post-pr-review step 5 so a draft staged in an earlier session gets the same pass. The pass edits the staged file; the existing "post the body verbatim" rule is unchanged, since tightening finishes the draft rather than rewriting it at gh invocation time. The prose bullet also settles a question that came up directly: a compressed conversational style in effect during a session does not carry into a review body, which goes to collaborators who never opted into it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rlcee
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both review skills already say that length is not thoroughness, but neither had a step where that rule fires. It did not fire on Mu2e/Offline#1933: that review shipped a full Evidence/Impact/Suggested-fix block on an S3 nit, and a residual-risk bullet caveating a hand analysis that duplicated an overlap check CI had already run and passed.
reviewing-pull-requests— new "Tightening pass — before the gates" subsection under Publishing the Review, plus a pointer from workflow step 6. Six concrete cuts: findings that restate instead of prove; ⚪/🟡 carrying the full three-part shape; residual-risk bullets caveating work that should not have been done; 🟢s naming no file or command; length tracking effort rather than blast radius; telegraphic prose instead of sentences.post-pr-review— new step 5 referencing that section, so a draft staged in an earlier session or hand-edited since gets the same pass. Version 1.2.0 → 1.3.0.The pass edits the staged file before the gates run. The existing "post the body verbatim, never rewrite at post time" rule is unchanged — tightening finishes the draft, it does not rewrite it at
ghinvocation time.The prose bullet settles a question that came up directly: a compressed conversational style in effect during a session does not carry into a review body, which goes to collaborators who never opted into it. Same boundary as commit messages and documentation.
Independent of #15 — no shared commits, no overlapping hunks, either order merges cleanly.
🤖 Generated with Claude Code