Drop the Helm chart lint job - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lint-helmjob points kubeconform at the chart directory:kubeconform reads those files as plain YAML, but the templates are Go
templates, so every one of them fails to parse regardless of what the chart
contains:
The job is gated on
ci/helm-chart/**, so it only runs when the chart changesand has gone unnoticed. It surfaced on #3, a three-line version bump, where it
was the only red check.
Rendering first (
helm template ci/helm-chart | kubeconform -) would make itwork, but #4 establishes that this chart is published nowhere and is bumped by
hand. A lint that has never passed, guarding an unpublished artifact, costs
more as noise on every future chart bump than it returns, so it is removed
rather than fixed.
The
helmpaths-filter and thehelmoutput on thechangesjob go with it —lint-helmwas their only consumer.🤖 Generated with Claude Code