Skip to content

auto toggle home row switches when pushing related home row - #255

Open
jmawet wants to merge 1 commit into
Moonfin-Client:masterfrom
jmawet:home-row-toggles-2
Open

auto toggle home row switches when pushing related home row#255
jmawet wants to merge 1 commit into
Moonfin-Client:masterfrom
jmawet:home-row-toggles-2

Conversation

@jmawet

@jmawet jmawet commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Now when users push a genre/collection/playlist row, moonbase will automatically toggle the displayXRows home row toggle, so that the rows will actually show for users when pushed to them

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • API / endpoint change
  • Settings schema change
  • Documentation update
  • Build/CI change
  • Other (describe):

Area

  • Settings sync / profiles
  • Admin defaults / config page
  • Ratings (MDBList / TMDB)
  • Notifications / Push (FCM / relay)
  • Seerr integration
  • Games / Emulators
  • Custom home rows
  • Web Client (Go to Moonfin-Core repo)
  • Other / shared

Changes Made

List the key changes included in this PR.

  • before saving the home rows list, go through and check if any of them need their toggles enabled (regardless of what was previously set for the toggles)
  • fixed a typo with a missing '<' causing formatting issues (lol)

Client Impact

Does this need matching changes in a client repo (Core, Smart-TV, Roku)?

  • No client changes needed
  • Companion client PR(s) required, linked here:
  • New setting keys added. List each key and confirm it matches the client key exactly, including casing:

Compatibility

  • Change to the settings profile is additive only, no renamed or removed properties
  • New properties use the same type the client sends (a client bool maps to bool?, an int to int?)
  • Migration added for any renamed or removed settings
  • Older clients still work, unknown fields are ignored and no keys were removed

Testing

Describe how this change was tested.

  • Built the plugin and deployed to a Jellyfin server
  • Verified against a live client (which one: core android mobile)
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. add 1 or more genre/collection/playlist row(s)
  2. save defaults
  3. refresh the page
  4. see the toggles are now set to "yes"
  5. optionally, push to a user
  6. the user will now have those toggles enabled, and the rows show up automatically

Screenshots (if applicable)

Include config page screenshots or request/response samples where relevant.
image

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced
  • Any new setting keys match the client-side keys exactly

@github-actions

Copy link
Copy Markdown

Build Successful

The plugin compiled successfully against .NET 8 / Jellyfin 10.10.0.

Property Value
Commit c707a09
Workflow Build #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant