Skip to content

bugfix-mediadetails - Moonbase Does TV Studios - #252

Open
mattsigal wants to merge 1 commit into
Moonfin-Client:masterfrom
mattsigal:feature/include-tmdb-networks-studio-logos
Open

bugfix-mediadetails - Moonbase Does TV Studios#252
mattsigal wants to merge 1 commit into
Moonfin-Client:masterfrom
mattsigal:feature/include-tmdb-networks-studio-logos

Conversation

@mattsigal

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Includes TMDB networks alongside production companies when fetching studio logos for TV shows.

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • API / endpoint change
  • Settings schema change
  • Documentation update
  • Build/CI change
  • Other (describe):

Area

  • Settings sync / profiles
  • Admin defaults / config page
  • Ratings (MDBList / TMDB)
  • Notifications / Push (FCM / relay)
  • Seerr integration
  • Games / Emulators
  • Custom home rows
  • Web Client (Go to Moonfin-Core repo)
  • Other / shared

Changes Made

List the key changes included in this PR.

  • Updated StudioLogoFetchService.cs to deserialize networks in addition to production_companies when querying TMDB TV item details (/3/tv/{id}).
  • Enables caching and returning logo images for major TV networks (such as Apple TV+, AMC, HBO, Hulu, etc.) on TV show detail screens.

Client Impact

Does this need matching changes in a client repo (Core, Smart-TV, Roku)?

Compatibility

  • Change to the settings profile is additive only, no renamed or removed properties
  • New properties use the same type the client sends (a client bool maps to bool?, an int to int?)
  • Migration added for any renamed or removed settings
  • Older clients still work, unknown fields are ignored and no keys were removed

Testing

Describe how this change was tested.

  • Built the plugin and deployed to a Jellyfin server
  • Verified against a live client (which one:)
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Built Moonfin.Server.dll and deployed to Jellyfin plugins folder.
  2. Verified that TMDB network logos for TV titles are fetched and returned via /Moonfin/Tmdb/ProductionCompanies.
  3. Verified live logo rendering on TV show detail screens (e.g., Deadwood, Dark Winds).

Screenshots (if applicable)

Include config page screenshots or request/response samples where relevant.

Screenshots included on Moonfin-Client/Moonfin-Core#1240

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced
  • Any new setting keys match the client-side keys exactly

… studio logos

Fetch and cache TMDB network logos in addition to production company logos
so TV show networks (Apple TV+, AMC, HBO, etc.) return logo URLs.
@github-actions

Copy link
Copy Markdown

Build Successful

The plugin compiled successfully against .NET 8 / Jellyfin 10.10.0.

Property Value
Commit e068fe8
Workflow Build #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant