Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some libraries like RxSwift ship symlinks in their repositories. We noticed that it causes problems when navigating to the symlinked sources when they are in Bazel's external repositories directory via "jump to definition". Typically it works the first time and second time Xcode refuses to jump.
I traced the issue to the resolution of the symlinks where we resolved the file symlink but leave the parent directory unresolved, which causes Xcode to open sources at paths that don't match their build settings and break navigation.
so we now resolve the parent directory symlinks too.