Skip to content

Add a versioned build proxy manifest - #3328

Open
karim-alweheshy wants to merge 3 commits into
mainfrom
build-proxy-manifest-schema
Open

karim-alweheshy wants to merge 3 commits into
mainfrom
build-proxy-manifest-schema

Conversation

@karim-alweheshy

Copy link
Copy Markdown
Contributor

Summary

  • Add a deterministic schema-v2 build-proxy manifest to generated Xcode projects.
  • Bind project identity, target GUIDs, Bazel labels, target IDs, variants, operation capabilities, and output groups.
  • Keep projects without proxy configuration unchanged.

Stack

Validation

  • git diff --check passes at this exact endpoint.
  • The combined stack passes the repository test matrix; exact-layer CI is expected on this draft.

Testing

Run the manifest analysis and generation tests, regenerate the Sanitizers fixture twice, and verify byte-identical schema-v2 output plus unchanged generation when proxy attributes are absent.

Karim Alweheshy added 3 commits September 5, 2026 10:15
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
@karim-alweheshy
karim-alweheshy force-pushed the build-proxy-manifest-schema branch from 32b9711 to 626d5f9 Compare September 5, 2026 08:51
@karim-alweheshy

Copy link
Copy Markdown
Contributor Author

Rebased and normalized the complete build-proxy review stack onto current main.

For this root slice specifically, the old branch-only dependency/archive duplicates were dropped where already present on main; the three actual manifest commits were replayed patch-identically. The resulting head is 626d5f9d9dde4d9717c7145c992946bef0e0dd68 and GitHub reports it mergeable against current main.

The downstream review chain is now a single linear 23-commit DAG through #3339. All 12 intended edge relationships, changed-path sets, commit counts, dropped duplicates, and stable patch IDs were mechanically verified. Four focused build-proxy test targets pass on the final endpoint.

Because this repository uses squash-only merges, I am marking only this root slice ready. The downstream slices will remain draft and mechanically mergeable against their updated stack bases until each parent is promoted; then they can be retargeted/replayed one at a time.

@karim-alweheshy
karim-alweheshy marked this pull request as ready for review September 5, 2026 08:54
@karim-alweheshy
karim-alweheshy requested a review from a team as a code owner September 5, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant