Correct BuildDependsOn in how-to-extend-the-visual-studio-build-proce… - #11426
Correct BuildDependsOn in how-to-extend-the-visual-studio-build-proce…#11426Joel Davies (daviesj) wants to merge 1 commit into
Conversation
…ss.md BuildDependsOn in the default target files does not include $(BuildDependsOn). Remove that line to make it match code at https://github.com/dotnet/msbuild/blob/6680032d11ab4bf746983a0fe791274beaf2864a/src/Tasks/Microsoft.Common.CurrentVersion.targets#L917
|
Joel Davies (@daviesj) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
1 similar comment
|
Joel Davies (@daviesj) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit e719da4: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Pull request overview
Updates an MSBuild documentation example to correctly reflect how BuildDependsOn is defined in the default common targets, aligning the guidance with current MSBuild behavior and avoiding an incorrect self-referential property expansion in the default definition.
Changes:
- Removes
$(BuildDependsOn);from the defaultBuildDependsOndefinition snippet to match MSBuild’sMicrosoft.Common.CurrentVersion.targets. - Keeps the later example (showing how to extend
BuildDependsOnby including$(BuildDependsOn)) as the correct customization pattern.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ss.md
BuildDependsOn in the default target files does not include $(BuildDependsOn). Remove that line to make it match code at https://github.com/dotnet/msbuild/blob/6680032d11ab4bf746983a0fe791274beaf2864a/src/Tasks/Microsoft.Common.CurrentVersion.targets#L917