Skip to content

Correct BuildDependsOn in how-to-extend-the-visual-studio-build-proce… - #11426

Open
Joel Davies (daviesj) wants to merge 1 commit into
MicrosoftDocs:mainfrom
daviesj:sdk_target_fix
Open

Correct BuildDependsOn in how-to-extend-the-visual-studio-build-proce…#11426
Joel Davies (daviesj) wants to merge 1 commit into
MicrosoftDocs:mainfrom
daviesj:sdk_target_fix

Conversation

@daviesj

Copy link
Copy Markdown

…ss.md

BuildDependsOn in the default target files does not include $(BuildDependsOn). Remove that line to make it match code at https://github.com/dotnet/msbuild/blob/6680032d11ab4bf746983a0fe791274beaf2864a/src/Tasks/Microsoft.Common.CurrentVersion.targets#L917

@prmerger-automator

Copy link
Copy Markdown
Contributor

Joel Davies (@daviesj) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

1 similar comment
@prmerger-automator

Copy link
Copy Markdown
Contributor

Joel Davies (@daviesj) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit e719da4:

✅ Validation status: passed

File Status Preview URL Details
docs/msbuild/how-to-extend-the-visual-studio-build-process.md ✅Succeeded

For more details, please refer to the build report.

@v-dirichards

Copy link
Copy Markdown
Contributor

RoseHJM

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates an MSBuild documentation example to correctly reflect how BuildDependsOn is defined in the default common targets, aligning the guidance with current MSBuild behavior and avoiding an incorrect self-referential property expansion in the default definition.

Changes:

  • Removes $(BuildDependsOn); from the default BuildDependsOn definition snippet to match MSBuild’s Microsoft.Common.CurrentVersion.targets.
  • Keeps the later example (showing how to extend BuildDependsOn by including $(BuildDependsOn)) as the correct customization pattern.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants