Skip to content

feat(pr-workflow): add /mms-debug orchestrator - #98

Draft
MajorLift wants to merge 4 commits into
mainfrom
jongsun/add/debug-orchestrator
Draft

feat(pr-workflow): add /mms-debug orchestrator#98
MajorLift wants to merge 4 commits into
mainfrom
jongsun/add/debug-orchestrator

Conversation

@MajorLift

@MajorLift MajorLift commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Overview

Adds one skill, debug, at domains/pr-workflow/skills/debug/skill.md. Its instructions are a routing table: hand it a symptom, it routes to the skill that owns that defect class — memory-leak, race-condition-repro, react-render-delta, sentry-grafana-correlation, extension-errors-debugging, tsc-blindspots, supply-chain-audit. It reimplements none of them; the routing decision is the addition, not the investigation.

Motivation

Those seven are invocable by anyone who knows which they need; debug is for when you have a symptom and do not. It is evidence's symptom-first sibling (#84), whose trust gates it carries: evidence starts from a claim and looks for what would falsify it; debug must generate the hypothesis first. Killed hypotheses are part of the output.

debug also leans on distinguishing-observation and observability-gap, from #106.

Showcase

  • node .github/scripts/lint-skill-entry.mjs domains/pr-workflow/skills/debug/skill.md — 0 errors, 0 warnings
  • Every skill named in the routing table exists or has an open PR

`pr-validate` is handed a claim and looks for the observation that would falsify
it. Debugging starts from a symptom and has to generate the hypothesis first,
which is where the expensive failure lives: the theory is yours, nobody else is
positioned to challenge it, and confirmation is cheap.

Routes the symptom to the engine that owns its defect class rather than
reimplementing any investigation, so both orchestrators share one set of engines.
Carries `pr-validate`'s trust gates, which bind harder here — a weak instrument
in review yields a claim someone challenges, in debugging it yields a theory
nobody checks.
@MajorLift MajorLift changed the title feat(pr-workflow): add debug orchestrator feat(pr-workflow): add /mms-debug orchestrator Jul 31, 2026
@MajorLift

Copy link
Copy Markdown
Contributor Author

Context budget

What this PR costs an agent, measured from an install rather than read from the diff. Three tiers, and only the first is unavoidable.

Skill Frontmatter Selected + refs & knowledge
debug 1,151 chars ~1,716 tok ~1,716 tok

Frontmatter is the only tier paid unconditionally — every agent loads it on every run once the skill is installed, used or not, because it is what the agent reads to decide relevance. The 28 skills across the eleven open skill PRs sit at a median of ~1,716 tokens selected and ~1,860 with references followed. All are within the 1,536-character description budget.

Selected is paid only when the agent picks the skill. + refs & knowledge is the ceiling if every bundled reference is then read; it is a worst case, not an expectation.

Method

tools/install --repo metamask-extension --maturity experimental against this branch at 703242599, measured per installed skill directory. Repo overlays are merged into the emitted SKILL.md, so they land in the selected tier rather than being missed by a source-byte count. Token figures are bytes/4 — a proxy for scale, not accounting.

These figures are pinned to the commit above and drift on every push; #96 tracks automating them.

MajorLift added a commit that referenced this pull request Aug 4, 2026
Adds #44 (platform), #69 (typescript), #90 (privacy-egress-diligence),
#91 (agent-run-cost) and #98 (mms-debug). The first nine were taken from an
earlier sync list rather than an enumeration of open PRs, which is how these
were missed.
The installer emits `mms-debug`; the description advertised `/debug`.
The symptom table and the description both named `react-render-proof`. No skill
of that name exists on `main` or in any open pull request; the render engine is
`react-render-delta`, added by #43 and carried by #84 and #108, and installed
locally as `mms-react-render-delta`.

The other six engines this skill routes to all resolve to skills in open pull
requests, so this was the only wrong name rather than one of three. Checked
against the repository rather than against an install: none of the seven is on
`main` yet, which is a merge-ordering fact and not a defect here.

Nothing validates this today. #103, which would have checked cross-skill
references, was closed as superseded by #87, and #87 is not merged — so this
name would have shipped unflagged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant