ci(lint): Fix universal installs being accepted by default by flagging missing repo overlays - #141
Open
MajorLift wants to merge 1 commit into
Open
ci(lint): Fix universal installs being accepted by default by flagging missing repo overlays#141MajorLift wants to merge 1 commit into
MajorLift wants to merge 1 commit into
Conversation
Repo targeting is declared by the shape of `repos/`, not by its contents, and the two shapes mean opposite things. `tools/install` skips a skill whose `repos/` exists but holds no file for the target repo; a skill with no `repos/` installs everywhere. So adding one overlay to a skill that had none narrows it from every repo to that one, and the skill keeps installing correctly in the repo the author was looking at. Both directions are legitimate, so both are warnings rather than errors: 41 of 53 skills on `main` have partial coverage and 11 have none, and the tool skills among them are genuinely repo-agnostic. The warning names the excluded repos and the consequence so the choice is visible at review time.
MajorLift
changed the title
MajorLift
changed the title
MajorLift
changed the title
MajorLift
marked this pull request as ready for review
August 31, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A skill with no
repos/directory installs into every consuming repo —core,metamask-extension,metamask-mobile. That is the default, so nobody chose it and no reviewer sees a decision to question.This adds two
lint-skill-entrywarnings so the omission is visible at review.Motivation
Targeting is declared by the shape of
repos/, and the two shapes mean opposite things:repos/→ installs into every reporepos/→ only the repos it names;tools/install:477skips it for any repo with norepos/<repo>.mdSo the obvious fix makes it worse. Adding one overlay to a skill that had none does not widen it — it narrows it to that repo alone, silently, because the skill still installs correctly in the repo whose overlay was just written.
Hence two warnings: one for reach nobody declared, one for reach a well-meant overlay has quietly removed.
Warnings, not errors: 11 skills on
maincarry norepos/, and several are genuinely repo-agnostic (codex,gator-cli,x402-payments). Erroring today would fail correct work.Showcase
Across
main, of 53 skills: 41 partial coverage, 11 norepos/, 1 full. Most partial coverage is deliberate; the 11 are the queue.lint-skill-entry: 53 skills checked, 0 errors, 143 warnings — 52 new here, 91 pre-dating this change.