feat: add analytics skill with MetaMask Mobile overlay - #140
Open
NicolasMassart wants to merge 1 commit into
Open
feat: add analytics skill with MetaMask Mobile overlay#140NicolasMassart wants to merge 1 commit into
NicolasMassart wants to merge 1 commit into
Conversation
- Introduced a new `analytics` skill that provides a repo-agnostic base and integrates a MetaMask Mobile overlay for the canonical tracking API. This skill is marked as `mandatory: true`, ensuring it installs even when the `coding` domain is filtered out. - Updated documentation in `README.md` to clarify the behavior of `mandatory: true` in relation to domain filtering.
There was a problem hiding this comment.
Pull request overview
Adds a new repo-agnostic analytics skill and a MetaMask Mobile-specific overlay documenting the canonical analytics tracking API and testing patterns, and updates top-level docs/changelog to reflect mandatory: true installation behavior.
Changes:
- Add new
analyticsskill (markedmandatory: true) with a basic workflow for event selection, building, emission, and test mocking. - Add
metamask-mobileoverlay documenting canonical tracking entry points and example usage/mocking patterns. - Document
mandatory: truebehavior inREADME.mdand record the addition inCHANGELOG.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Documents how mandatory: true interacts with domain filtering and excludes. |
| domains/coding/skills/analytics/skill.md | Introduces the base analytics skill with frontmatter and a simple workflow. |
| domains/coding/skills/analytics/repos/metamask-mobile.md | Adds MetaMask Mobile overlay describing canonical tracking APIs, examples, and test mocking guidance. |
| CHANGELOG.md | Notes the new analytics skill and its mandatory: true behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| ## Canonical API | ||
|
|
||
| Two emission paths. Use one of them; do not add a third. |
| Controllers that already talk to Engine should call | ||
| `messenger.call('AnalyticsController:trackEvent', event)` with a built event. | ||
|
|
||
| ## Require |
Comment on lines
+27
to
+28
| Controllers that already talk to Engine should call | ||
| `messenger.call('AnalyticsController:trackEvent', event)` with a built event. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a repo-agnostic
analyticsskill plus a MetaMask Mobile overlay that documents the canonical tracking API (useAnalytics,analytics.trackEvent,AnalyticsController:trackEvent), event catalog usage, and test mocking viacreateMockUseAnalyticsHook.The skill is marked
mandatory: trueso it installs even when thecodingdomain is filtered out. README documents thatmandatory: truebehavior (--exclude/SKILLS_EXCLUDEstill wins).Type of Change
Skill Details (if adding a new skill)
Provider Name: MetaMask
Skill Name: analytics
Brief Description: Product analytics and event tracking guidance, with a MetaMask Mobile overlay for the canonical tracking API.
Checklist
Testing
yarn audit:skillsaccepts the new skill frontmattermandatory: truestill installs the skill when thecodingdomain is filtered out--exclude/SKILLS_EXCLUDEstill skips it when explicitly excludedAdditional Context
MCWP-826
Made with Cursor