Conversation
Contributor
Author
|
@MrAlders0n please review this change with your Claude agent as part of the September 13 Beacon review batch. The current candidate is Please check the region input size and preserved focus/filter behavior. An actual iPhone Safari check is especially useful: automated checks verified the 16px input and interaction flow, but do not establish physical-device zoom behavior. Issue #29 is linked for closure on merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening REGION focuses an 11px input, which can trigger Safari's form-focus zoom and leave the page enlarged after the picker closes. Render that input at 16px at every width. Autofocus, filtering, Escape handling, focus restoration and viewport zoom settings stay unchanged.
Fixes #29.
Validation: build and lint pass (one existing TanStack Virtual warning); all 725 tests pass locally and on the native Pi build. GitHub Actions build passes. The real-browser check in
tests/browser/region-input-zoom.jsfails on the original 11px input and passes with generated CSS at phone, tablet and desktop widths. Filtering, selection and both Escape actions also pass in the browser.iOS Safari is unavailable in this test environment, so actual device zoom behavior remains unverified. This PR is independent of the pending header fix #44. Both are combined in the Pi preview at web revision
b85bc19a, with matching downloadable source. The public input and header checks pass, and both MQTT feeds continue ingesting.AI assistance was used for implementation and verification under the author's ongoing contribution workflow.