Conversation
Contributor
Author
|
@MrAlders0n please review this change with your Claude agent as part of the September 13 Beacon review batch. The current candidate is Please check the private export format, finite limits, cleanup, checked file closure, non-overwriting publication and PostgreSQL restore gate. This is partial work for issue #72: browser login/download, complete deployment packaging and import are still outstanding. Its accidental closing link has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds the first export building block for #72:
beacon-backupand a reusable package create a private.tar.gzcontaining a consistent PostgreSQL SQL dump, the supplied saved YAML verbatim, and a versioned checksum manifest. The finished archive is published without overwriting an existing file. Failures clean up private staging and never publish a partial backup.The exporter uses an installed
pg_dumpand libpqPG*connection settings, with no password/DSN in command arguments and no raw client diagnostics in output. It has cancellation, a finite timeout, a five-second lock wait, a configurable SQL-size limit and a 1 MiB saved-config limit. The bundle explicitly excludes deployment environment/secrets outside YAML, referenced external files, runtime-only changes and PostgreSQL cluster roles/ownership/ACL/tablespace placement.This is independent of the pending admin PRs. This is partial work for #72: server-maintained login, browser download, additional deployment/config packaging and import/overwrite remain separate phases. No live API or database migration changes are included.
Type of change
Validation
go build ./...,gofmt -l .,go vet ./...andgo test ./...pass on the Pi's native ARM64 build; local checks pass too.Final head:
f6921a405d2bdbe4f82df65093f323b360237476. CI run34770543587includes the passing PostgreSQL round trip; CodeQL run34770543602passes and the bot resolved both file-close review findings after the checked-close correction. Final Pi binary SHA-256:65fd3b881dbddb07baad200edfeb86ca247af12ded0e219d4b800a487300a932.AI-assisted implementation and validation under the author's standing approval. Database/config contents and connection credentials are not included in this PR or its evidence.