Conversation
This was referenced Sep 13, 2026
Open
Contributor
Author
|
@MrAlders0n please review this change with your Claude agent as part of the September 13 Beacon review batch. The current candidate is Please check cache hit/miss/error diagnostics without private keys/values or behavior changes. Issue #51 requires both #144 and this PR. Preferred sequence: merge this cache slice first, then complete the logging controls in #144 and add the closing reference there. The issue remains open while either required part is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Add debug records for cache hits, misses, invalid entries and Redis read-error bypasses. Each record identifies the cache component without including a cache key, value or raw Redis error. Fetch and fallback behavior stays unchanged, and info-level operation remains quiet.
Related to #51. This is independent of logging-controls PR #144: it uses the standard
slogdefault logger and becomes visible when a debug handler is configured.Type of change
Checklist
go build ./...passesgofmt -l .is emptygo vet ./...passesgo test ./...passesTesting notes
Native Pi 5 build, vet and full tests pass with PostgreSQL tests enabled. The cache suite and focused Windows race check pass. A miniredis regression verifies miss/hit/corrupt-entry records, fetch/result behavior, absence of synthetic private keys/values and silence at info level.
CI and CodeQL pass. The combined Pi preview includes this change with #144; JSON/info operation is quiet for cache diagnostics, both feeds advance and public API/WebSocket checks pass. Debug behavior is verified by the native cache tests.
AI-assisted implementation and testing under the contributor's standing authorization; submitted for maintainer review.