Conversation
Contributor
Author
|
@MrAlders0n please review this change with your Claude agent as part of the September 13 Beacon review batch. The current candidate is Please review the advert-summary history/live contract together with MeshCore-Beacon/beacon-web#46. Issue #99 remains open: please confirm whether the advert example completes the intended scope or identify the other required packet summaries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Populate the existing optional
PacketSummary.summarywith an advert's own stored name, and carry the same name in livepacketObservation.packet.summary. Global lists, IATA-filtered lists and reconnect backfill all include it. Historical names come from packet metadata rather than a mutable current node record.Addresses the advert-name example in #99. Empty/missing names, unsupported packet types and unverified live adverts omit the field. Other payload-summary formats remain separate follow-ups.
Type of change
Checklist
Testing notes
The original live event fails the named-advert regression. Signed-wire tests cover ordinary and Unicode names, invalid UTF-8 normalization, absent/empty names and tampered signatures in both event variants. Native PostgreSQL tests cover historical and backfill responses, missing observations, invalid metadata shapes and unsupported types; each list/backfill read remains one query.
Standalone and combined native Pi builds pass the full Go suite with PostgreSQL enabled. GitHub Actions CI and CodeQL pass. Web PR #46 displays the optional field while retaining endpoints and older-server compatibility.
The Pi preview runs server
c955ac43and web120ec73d, with matching downloadable source. Live checks matched three global, three regional and three backfill summaries to the packet metadata, plus one newly received WebSocket advert. Desktop/mobile rendering and expansion checks pass; both MQTT feeds remain connected and advancing. Test receipts retain aggregate outcomes only.AI assistance was used for implementation and verification under the author's ongoing contribution workflow.