Avoid initialization race in pool inactivity test - #1365
Merged
Merged
Conversation
Pool connections start their idle timers as soon as they connect. If opening the second connection takes longer than 200 ms, the first can expire before pool initialization finishes. This makes the initial holder assertions in `test_pool_max_inactive_time_05` fail intermittently. Register termination listeners through the init callback and wait for both connections to close with a bounded timeout. Leave both connections unacquired and verify their creation, closure, and holder cleanup. This accepts expiry during initialization while still detecting missing idle cleanup, without relying on fixed sleeps.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The test reliably handles initialization expiry and verifies cleanup.
Review effort: Lite
Findings: None
What changed in this PR
Updates the pool inactivity test to avoid initialization timing races and reliably verify cleanup.
Changes:
- Register termination listeners during initialization.
- Wait for both idle connections to close with a bounded timeout.
- Verify connection closure and holder cleanup.
| File | Summary |
|---|---|
tests/test_pool.py |
Makes the inactivity test race-resistant and validates cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool connections start their idle timers as soon as they connect. If
opening the second connection takes longer than 200 ms, the first can
expire before pool initialization finishes. This makes the initial
holder assertions in
test_pool_max_inactive_time_05failintermittently.
Register termination listeners through the init callback and wait for
both connections to close with a bounded timeout. Leave both connections
unacquired and verify their creation, closure, and holder cleanup. This
accepts expiry during initialization while still detecting missing idle
cleanup, without relying on fixed sleeps.