Skip to content

Add PyPI classifiers to pyproject.toml - #51

Open
elhoim wants to merge 1 commit into
MISP:mainfrom
elhoim:fix/44-add-classifiers
Open

Add PyPI classifiers to pyproject.toml#51
elhoim wants to merge 1 commit into
MISP:mainfrom
elhoim:fix/44-add-classifiers

Conversation

@elhoim

@elhoim elhoim commented Aug 31, 2026

Copy link
Copy Markdown
Member

Finding 44 (Low) — pyproject.toml:5

Problem

The [project] table declares no classifiers at all, so the package does not appear under PyPI's classifier-based filters and search facets.

Fix

Finding 44 (low, add-classifiers): pyproject.toml's [project] table declared no classifiers field, so the package wouldn't surface under PyPI's classifier-based filters/search facets. Added Development Status, Intended Audience, License, and Programming Language classifiers — the license classifier (AGPLv3) and Python version range (3.10-3.12) were chosen to match the repo's actual LICENSE file and the requires-python = ">=3.10" constraint already in pyproject.toml.

Verification

Reproduced against the unmodified code at 9b8c605, then re-checked after the change.

Before
Inspection (this is a packaging-metadata finding, no runtime behaviour): `python3 -c "import tomllib; print(tomllib.load(open('pyproject.toml','rb'))['project'].get('classifiers'))"` on the base commit raises KeyError / prints nothing — no `classifiers` key exists. Confirmed via `git show 9b8c6052...:pyproject.toml | grep classifiers` → no match. Building the sdist (`python3 -m build --sdist`) and inspecting `PKG-INFO` shows zero `Classifier:` lines.
After
After the fix, `python3 -m build --sdist --outdir /tmp/build_out .` succeeds and `grep -i classifier misp_modules_cli.egg-info/PKG-INFO` shows 7 Classifier lines: Development Status :: 4 - Beta; Intended Audience :: Information Technology; License :: OSI Approved :: GNU Affero General Public License v3; Programming Language :: Python :: 3, 3.10, 3.11, 3.12.

python bin/cli.py --help exits 0 and the module still imports cleanly. Verification was performed offline against the pure functions — no running misp-modules instance is required.

Branched from 9b8c605. This PR addresses only this finding; the other findings from the same review are in separate PRs, so they will need rebasing against each other as they merge.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DYX4TKA5inzByJ4qGWKjqh

The [project] table declared no classifiers, so the package doesn't surface under PyPI's classifier-based filters/search facets. Add Development Status, Intended Audience, License, and Programming Language classifiers matching the package's supported Python versions and AGPLv3 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant