Skip to content

Fix backslash-unaware pipe escaping in markdown tables #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elhoim wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Fix backslash-unaware pipe escaping in markdown tables #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bin/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,19 +406,19 @@ def response_to_table(response: Any) -> List[str]:
return ["| Key | Value |", "| --- | --- |", "| _(empty)_ | |"]
lines = ["| Key | Value |", "| --- | --- |"]
for key in sorted(response.keys()):
safe_key = str(key).replace("\n", " ").replace("|", "\\|")
safe_value = to_inline(response[key]).replace("\n", " ").replace("|", "\\|")
safe_key = str(key).replace("\n", " ").replace("\\", "\\\\").replace("|", "\\|")
safe_value = to_inline(response[key]).replace("\n", " ").replace("\\", "\\\\").replace("|", "\\|")
lines.append(f"| `{safe_key}` | {safe_value} |")
return lines
if isinstance(response, list):
if not response:
return ["| Index | Value |", "| --- | --- |", "| 0 | _(empty)_ |"]
lines = ["| Index | Value |", "| --- | --- |"]
for idx, item in enumerate(response):
safe_value = to_inline(item).replace("\n", " ").replace("|", "\\|")
safe_value = to_inline(item).replace("\n", " ").replace("\\", "\\\\").replace("|", "\\|")
lines.append(f"| `{idx}` | {safe_value} |")
return lines
safe_value = str(response).replace("\n", " ").replace("|", "\\|")
safe_value = str(response).replace("\n", " ").replace("\\", "\\\\").replace("|", "\\|")
return ["| Value |", "| --- |", f"| `{safe_value}` |"]

generated_at = datetime.now(timezone.utc).strftime("%Y-%m-%d %H:%M:%SZ")
Expand Down