Add filename|sha512 detection to looks_like_filename_hash - #40
Open
elhoim wants to merge 1 commit into
Open
Conversation
looks_like_filename_hash checked md5/sha1/sha256 but never sha512, even though looks_like_sha512 already existed. As a result, values like 'malware.exe|<128 hex chars>' were never suggested as the valid MISP type filename|sha512. Add the missing sha512 branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding 23 (Medium) —
bin/cli.py:213-226Problem
looks_like_filename_hash checks md5/sha1/sha256 but never sha512, although looks_like_sha512 exists. 'malware.exe|'+128 hex returns (False, []), so the valid MISP type filename|sha512 is never suggested.
Fix
looks_like_filename_hash() in bin/cli.py checked candidate hash values against md5/sha1/sha256 only, even though a looks_like_sha512() helper already existed elsewhere in the file. As a result, a value like "malware.exe|<128 hex chars>" was never recognized and the valid MISP attribute type filename|sha512 was never suggested to the user. The fix adds the missing
if looks_like_sha512(right): candidates.append("filename|sha512")branch, mirroring the existing md5/sha1/sha256 branches exactly.Verification
Reproduced against the unmodified code at
9b8c605, then re-checked after the change.Before
After
python bin/cli.py --helpexits 0 and the module still imports cleanly. Verification was performed offline against the pure functions — no runningmisp-modulesinstance is required.Branched from
9b8c605. This PR addresses only this finding; the other findings from the same review are in separate PRs, so they will need rebasing against each other as they merge.🤖 Generated with Claude Code
https://claude.ai/code/session_01DYX4TKA5inzByJ4qGWKjqh