Skip to content

Require AS prefix for high-confidence ASN detection #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elhoim wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Require AS prefix for high-confidence ASN detection #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bin/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,11 @@ def looks_like_email(value: str) -> bool:


def looks_like_asn(value: str) -> bool:
return bool(re.match(r"^(AS)?\d{1,10}$", value, re.IGNORECASE))
return bool(re.match(r"^AS\d{1,10}$", value, re.IGNORECASE))


def looks_like_bare_asn_digits(value: str) -> bool:
return bool(re.match(r"^\d{1,10}$", value))


def looks_like_cve(value: str) -> bool:
Expand Down Expand Up @@ -286,6 +290,8 @@ def add(t: str, reason: str, score: int) -> None:

if looks_like_asn(v):
add("AS", "matches ASN syntax", 90)
elif looks_like_bare_asn_digits(v):
add("AS", "bare digits could be an ASN without the 'AS' prefix", 20)

if looks_like_domain(v):
add("domain", "looks like a domain name", 85)
Expand Down