Skip to content

Prune expired cache entries on save #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elhoim wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

Prune expired cache entries on save #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions bin/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,21 @@ def set_cached_response(cache: Dict[str, Any], key: str, response: Dict[str, Any
}


def prune_expired_entries(cache: Dict[str, Any], now: int, ttl_seconds: int) -> int:
entries = cache.get("entries", {})
if not isinstance(entries, dict):
return 0
expired_keys = [
key for key, entry in entries.items()
if not isinstance(entry, dict)
or not isinstance(entry.get("cached_at"), int)
or now - entry.get("cached_at", 0) > ttl_seconds
]
for key in expired_keys:
del entries[key]
return len(expired_keys)


def configure_module(
modules: List[Dict[str, Any]],
config_path: str,
Expand Down Expand Up @@ -1087,6 +1102,11 @@ def main() -> int:
f.write(markdown_report)
log(f"Wrote markdown report to {args.markdown_output}")

pruned = prune_expired_entries(cache, now=int(time.time()), ttl_seconds=args.cache_ttl_seconds)
if pruned:
log(f"Pruned {pruned} expired cache entr{'y' if pruned == 1 else 'ies'}.")
cache_dirty = True

if cache_dirty:
try:
save_cache(args.cache_file, cache)
Expand Down