fix: render both listings when --list-supported-types and --list-active-modules are combined - #32
Open
elhoim wants to merge 1 commit into
Open
fix: render both listings when --list-supported-types and --list-active-modules are combined#32elhoim wants to merge 1 commit into
elhoim wants to merge 1 commit into
Conversation
…ve-modules are combined Previously --list-supported-types returned before --list-active-modules was evaluated, so passing both flags silently produced only the first listing while still exiting 0 as if both had run. Now both listings render in sequence when both flags are given.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding 40 (Low) —
bin/cli.py:859-865Problem
--list-supported-types is checked and returns before --list-active-modules is evaluated, so passing both silently produces only the first listing and exits 0 as if both ran.
Fix
Finding #40 (both-list-flags, low severity): in bin/cli.py's main(), the --list-supported-types branch returned 0 unconditionally before --list-active-modules was checked, so passing both flags together silently rendered only the supported-types listing and exited 0 as though both had run. Fixed by making the early return conditional on --list-active-modules not also being set, so when both flags are given, both listings render in sequence (supported types, then active modules) before returning 0; when only one flag is given, behavior is unchanged.
Verification
Reproduced against the unmodified code at
9b8c605, then re-checked after the change.Before
After
python bin/cli.py --helpexits 0 and the module still imports cleanly. Verification was performed offline against the pure functions — no runningmisp-modulesinstance is required.Branched from
9b8c605. This PR addresses only this finding; the other findings from the same review are in separate PRs, so they will need rebasing against each other as they merge.🤖 Generated with Claude Code
https://claude.ai/code/session_01DYX4TKA5inzByJ4qGWKjqh