fix(devnet): quiet status-registry probes and bump evm-upgrade to v1.20.2 - #209
fix(devnet): quiet status-registry probes and bump evm-upgrade to v1.20.2#209akobrin1 wants to merge 1 commit into
Conversation
…20.2 - Add lookupStatusRegistryMnemonic, a silent registry lookup for probing infrastructure-key candidates that legitimately don't exist on a host (e.g. governance_key on a secondary validator), so probes no longer emit spurious WARN logs; readStatusRegistryMnemonic keeps warning for keys that are expected to be registered - Silence updateStatusRegistryAddress for untracked accounts: generated pre-evm-* fixtures live only in accounts-devnet.json, so a missing registry entry is the normal case - Remove unused appendStatusRegistryAccount - Fix Height format verb (%d -> %s) in supernode migration verification - Bump devnet-evm-upgrade target from v1.20.1 to v1.20.2 (via new devnet-upgrade-1202) - Add unit tests for status registry lookup helpers Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Line 717 in f6514bb
Separate the upgrade plan name from the binary version
When this target is run from the current post-v1.20.3 source tree, devnet-refresh-bin produces a binary stamped 1.20.3 (the CHANGELOG explicitly requires that binary for the on-chain v1.20.2 plan), but passing v1.20.2 here also makes upgrade-binaries.sh require the source binary's core version to be 1.20.2. Consequently, the flow can successfully schedule and halt the chain for v1.20.2 and then fail the binary swap with Source lumerad version mismatch, leaving the devnet halted; pass the plan name and expected binary version separately or otherwise permit the required 1.20.3 binary.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
lookupStatusRegistryMnemonic, a silent status-registry lookup used when probing infrastructure-key candidates that legitimately don't exist on a host (e.g.governance_keyon a secondary validator), eliminating spurious WARN logs;readStatusRegistryMnemonicstill warns for keys that are expected to be registeredupdateStatusRegistryAddressfor untracked accounts — generatedpre-evm-*fixtures live only inaccounts-devnet.json, so a missing registry entry is the normal caseappendStatusRegistryAccounthelperHeightformat verb (%d→%s) in supernode migration verification error messagesdevnet-evm-upgradeflow from v1.20.1 to v1.20.2 (newdevnet-upgrade-1202target)Test plan
go test ./devnet/tests/evmigration/...(status registry unit tests)make devnet-evm-upgradeend-to-end on the shared devnet host🤖 Generated with Claude Code