fix(match2): bo1 reset match display - #7947
Open
hjpalpha wants to merge 1 commit into
Open
Conversation
mbergen
reviewed
Sep 8, 2026
| if bestof == 1 and Info.config.match2.gameScoresIfBo1 and game1 and hasOnlyScores then | ||
| local mapOpponent = (game1.opponents or {})[ix] or {} | ||
| scoreDisplay = tonumber(mapOpponent.score) | ||
| status = mapOpponent.status |
Collaborator
There was a problem hiding this comment.
The status shouldn't change, right?
Collaborator
There was a problem hiding this comment.
Hmm, i guess it could be the case that a map-level forfeit is done. Which wouldn't make sense for a Bo1, but we've seen weirder things...
My initial thought was that when the match status is score, then for a Bo1 the same should hold for the map.
Collaborator
Author
There was a problem hiding this comment.
i agree that it is a rare edge case but as you said "we've seen weirder things..."
mbergen
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolves #7909
How did you test this change?
dev