fix(launchpad): colour the web link with the accent - #58
Merged
Merged
Conversation
A page for a link with no store URLs and no scheme has no primary button, so the accent colour changed nothing visible on it. The "Continue on the web" link now takes the accent, as the one action such a page has.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A page for a link with no store URLs and no URI scheme has no primary button, so
accentColorchanged nothing visible on it — a colour setting should do something on every page. "Continue on the web" now takes the accent (and a semibold weight so it reads as the page's action rather than a footnote). Focus rings already used it.One CSS rule, one test (a page with a web URL and no buttons contains the accent rule and no
lp-btn). 384 tests pass.