fix(review): address v1.0.6 audit findings - #117
Open
LimiNode wants to merge 5 commits into
Open
Conversation
Keep convenience aliases and the flat parser dispatch unchanged while fixing confirmed defects in constants, Release test assertions, installation configuration, documentation metadata, comments, include guards, and MQL5 manual test reporting. Add repository guidance for review and validation workflows.
Document the review, build, documentation, alias, and manual MQL5 validation workflow alongside the repository guard and test policies.
LimiNode
force-pushed
the
review/v1.0.6-audit-fixes
branch
from
September 8, 2026 19:32
dac2f18 to
5d0205f
Compare
Owner
Author
|
Rebased the PR branch onto the latest main (including #116's header-guard changes), resolved the MQL5 umbrella-header deletion consistently with upstream, and force-updated the branch. The PR is mergeable again. Rebased MinGW Release build/examples and CTest pass: 50/50; C++11/14/17 ODR targets also pass. |
Remove obsolete NDEBUG overrides now that runtime tests use TIME_SHIELD_TEST_CHECK. Select documentation versions from CMake on main and release tags, and publish documentation for v* tag pushes.
Escape the Markdown backticks correctly in the publish workflow and use the computed VERSION value directly.
Keep documentation sources version-neutral and inject the project or release-tag version during publication. Reject release tags that do not match the CMake project version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/mainpage.mdandDoxyfileversion-neutral; inject the documentation version during publish from CMake on main or the release tag on v* pushes.Validation
TIME_SHIELD_TEST_CHECK.git diff --checkpassed.Review notes