Remove SQL Server upgrade scripts and code - #988
Merged
Conversation
labkey-martyp
approved these changes
Aug 23, 2026
Contributor
|
@labkey-bpatel Might be worth looking at this PR to ensure it matches anything in your PR, if you haven't already. The AnimalsGroupAssignor.java jumps out. |
labkey-bpatel
approved these changes
Aug 24, 2026
labkey-bpatel
left a comment
labkey-bpatel
left a comment
Contributor
There was a problem hiding this comment.
Nothing here competes or duplicates the work I am doing. Looks good to me!
Regarding AnimalsGroupAssignor - my branch never touched it/not come across it just yet, so the getDate() / DATEADD fixes are new to me, I'll port them to my 26.3 fb separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We no longer support SQLServer as a primary DB
Changes
SupportedDatabasesinmodule.propertiesPostgresOnlyTest