Remove references to the retired MergeSync module - #977
Merged
labkey-martyp merged 2 commits intoAug 26, 2026
Conversation
LabworkRequestFormType declared a client dependency on MergeSync; ClientDependency.supplierFromModuleName throws IllegalArgumentException when the named module is absent. The registration for this form type is commented out in SNPRC_EHRModule, so the failure was latent rather than live. LabworkRequestDataEntryPanel no longer offers to open Merge after a commit, and LabworkRequestInstructionsFormSection is removed along with its instructions panel, which rendered Merge links and nothing else.
labkey-bpatel
approved these changes
Aug 10, 2026
labkey-bpatel
approved these changes
Aug 24, 2026
…fb_remove_mergesync_ogasync
labkey-martyp
commented
Aug 26, 2026
labkey-martyp
left a comment
labkey-martyp
left a comment
Contributor
Author
There was a problem hiding this comment.
These are not used in production so no test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Removes this module's last references to MergeSync, which is being retired. The labwork request form they belonged to is not registered, so none of this code was reachable at runtime.
Related Pull Requests
Changes