Use DatabaseCache for Attachments so they work with additions and deletions inside transactions - #7984
Open
labkey-susanh wants to merge 3 commits into
Open
Use DatabaseCache for Attachments so they work with additions and deletions inside transactions#7984labkey-susanh wants to merge 3 commits into
labkey-susanh wants to merge 3 commits into
Conversation
…etions inside transactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We have seen the DeleteJobAttachmentsApiTest.testMultipleAttachments test fail intermittently for a long time now saying that there are more attachments for a job than there actually are after deletion. The problem seems to be interference from the search indexer that picks up on the job that is created with its attachments in the setup for the test and makes a request to index that job concurrently with the deletion of the attachments. The deletion operation removes the attachments from the cache, but the indexer puts them back in before the transaction is committed, and there they will remain until they expire. Using a
DatabaseCacheshould make interactions during a transaction work better.Changes
Tasks 📍