Disable flaky ONPRC_EHRTest.testSubmitButtonsDisabledDuringValidation - #1866
Merged
labkey-martyp merged 1 commit intoAug 26, 2026
Merged
Conversation
The test asserts that 'Force Submit' is disabled while the data entry form validates, but that action carries disableOn 'SEVERE' and so is re-enabled the moment validation completes. Clicking 'More Actions' and waiting for the menu to render costs several seconds, which a fast validation pass beats, so the assertion loses the race and fails on TeamCity. Ignoring it until the assertion is reworked to sample state at validation start rather than chase it through the UI.
labkey-bpatel
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
ONPRC_EHRTest.testSubmitButtonsDisabledDuringValidationfails intermittently on the 26.3 ONPRC EHR suites and is blocking ONPRC work, so it is being disabled until the assertion can be reworked. The assertion is racy by construction:Force SubmitcarriesdisableOn: 'SEVERE', so it is disabled only while validation is in flight and is re-enabled the instant validation completes. ClickingMore Actionsand waiting for the Ext menu to render costs a few seconds, which a fast validation pass beats, and the 10-second wait for the disabled menu item then can never succeed. Every failure is the same one —ONPRC_EHRTest.java:2036onForce Submit— while the sibling checks pass regardless becauseSubmit And ReloadandSubmit Finalstay disabled after validation whenever the form has WARN/ERROR rows.Related Pull Requests
None.
Changes
@IgnoreontestSubmitButtonsDisabledDuringValidation, with the race recorded in the annotation message and a comment noting that it is blocking ONPRC work and should be re-enabled once the flakiness is resolved.