[bot] Merge 26.7 to develop - #26
Merged
Merged
Conversation
## Rationale Make the forms that open and close an animal's record agree on who owns each piece of its demographics, and finish the birth and conception cleanup this branch started with. The birth, arrival and death forms each wrote the animal's birth and death dates for themselves, so the three could disagree, and the death form additionally hand-set a status that the shared EHR recalculation already owns. Separately, the `nbri_ehr` schema still carried tables inherited from the legacy system that nothing reads, and several data entry forms exposed fields that are either derived or closed automatically and so were never meant to be typed by hand. ## Related Pull Requests None. ## Changes - Derive an animal's birth and death dates from its birth and death records, and leave calculated status to the shared EHR recalculation. Adds a drift query for reconciling values the old paths left stale. - Tighten birth and conception entry: conception date is now required, term date and birth condition are gone, and the birth fields the Start with Conception window fills can no longer be edited away from the conception record they came from. - Drop the legacy tables from the `nbri_ehr` schema along with the queries, custom views, lookups and referencing columns that existed only to serve them. Conception is the only table left in the schema. - Let an animal be put in a group as it arrives or is born, rather than through a separate form, and give the EHR roles access to the group membership data so the assignment can be closed when the animal dies. - Block recording a death against an animal whose demographics record is still in data entry, since that would publish unreviewed arrival or birth data. Admins can override. - Record a social code once per animal on the birth and arrival forms, and store it on demographics so it is available for animal selection and search. - Hide the end dates on the project and group assignment forms, which are always closed automatically rather than entered by hand, and rename the Bulk Deaths form to Deaths so it follows the same availability rules as every other data entry form. - Treat animals as cagemates when they share a location, which covers a group pen and a cage alike. - Stop reloading flag values from the production lookups manifest, so values configured at a site are no longer overwritten.
labkey-klum
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Merging changes from: 37afdd0
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
Verify all PRs before approving: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=fb_bot_merge_26.7