Remove SQL Server upgrade scripts and code - #431
Merged
Conversation
Author
|
@bbimber this repo was very straightforward. |
bbimber
previously requested changes
Aug 24, 2026
bbimber
left a comment
bbimber
left a comment
Collaborator
There was a problem hiding this comment.
Even though it's a change from existing behavior, I'd like to restore natural sorting on these columns for PG. I can check in a change unless you are able to.
Author
Sounds good. Go for it at your convenience. I've intentionally done these PRs such that they can be merged independently and then we'll do a followup small cleanup to actually delete things like the |
bbimber
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We no longer support SQLServer as a primary DB
Changes
SupportedDatabasesinmodule.propertiesPostgresOnlyTest