Skip to content

Remove SQL Server upgrade scripts and code - #301

Merged
labkey-jeckels merged 2 commits into
developfrom
fb_removeSqlServer2
Aug 24, 2026
Merged

Remove SQL Server upgrade scripts and code#301
labkey-jeckels merged 2 commits into
developfrom
fb_removeSqlServer2

Conversation

@labkey-jeckels

Copy link
Copy Markdown

Rationale

We no longer support SQLServer as a primary DB

Changes

  • Remove schema upgrade scripts
  • Remove SQLServer conditional code
  • Remove SupportedDatabases in module.properties
  • Remove uses of PostgresOnlyTest
  • Create Postgres version of covidseq schema

@labkey-jeckels
labkey-jeckels requested review from a team and bbimber August 23, 2026 16:56
@labkey-jeckels labkey-jeckels self-assigned this Aug 23, 2026
@labkey-jeckels

Copy link
Copy Markdown
Author

@bbimber the interesting thing for this repo is the covidseq module. It had no Postgres upgrade scripts. I did a trivial port (to be verified by TeamCity) to prevent schema validation failures. If this is a module worth migrating, you'll want to backport these changes to 26.3 or 26.7 so there's something to migrate into.

LEFT JOIN mgap.subjectsSource ss on (t.subjectId = ss.originalId)
LEFT JOIN mgap.animalMapping am on (t.subjectId = am.subjectname) No newline at end of file
-- Matched case-insensitively so an id whose alias-table spelling differs only in case still resolves; SampleSummaryCustomizer surfaces those as subjectCaseMismatch
LEFT JOIN mgap.animalMapping am on (LOWER(t.subjectId) = LOWER(am.subjectname)) No newline at end of file

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labkey-jeckels - this is an example of what I'm writing about here for PRIMe/EHR: https://www.labkey.org/ONPRC/Support%20Tickets/issues-insert.view?issueDefName=siteissues

@bbimber

bbimber commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

@labkey-jeckels: thanks for this. two points come up:

  1. covidseq is one of a few defunct modules that I would just as soon get rid of. I dont change modules much because it's gotten cumbersome to work with the distributions repo (i cant open PRs anymore). For our github actions-based workflows, I cloned the module lists (https://github.com/bimberlabinternal/DevOps/tree/master/githubActions/discvr-build/distributions/discvr), and the gradle framework works perfectly fine with the module hosting the module list, as opposed to needing one monolithic distributions repo.

That aside, we can eliminate covidseq and probably hivrc. I'm happy to address that separate from here.

  1. I appreciate the addition to this table to catch/identify case-sensitivity issues. This is one of many, many places that might need attention. I'm able to look at non-PRIMe/EHR instances, but this is a significant potential for difficult to detect see breaks in expected behavior.

I will also think about this, but I would really like to see us implement lower-level solutions to either avoid or at least identify case-sensitivity issues

@labkey-jeckels

Copy link
Copy Markdown
Author

@labkey-jeckels: thanks for this. two points come up:

  1. covidseq is one of a few defunct modules that I would just as soon get rid of. I dont change modules much because it's gotten cumbersome to work with the distributions repo (i cant open PRs anymore). For our github actions-based workflows, I cloned the module lists (https://github.com/bimberlabinternal/DevOps/tree/master/githubActions/discvr-build/distributions/discvr), and the gradle framework works perfectly fine with the module hosting the module list, as opposed to needing one monolithic distributions repo.

That aside, we can eliminate covidseq and probably hivrc. I'm happy to address that separate from here.

  1. I appreciate the addition to this table to catch/identify case-sensitivity issues. This is one of many, many places that might need attention. I'm able to look at non-PRIMe/EHR instances, but this is a significant potential for difficult to detect see breaks in expected behavior.

I will also think about this, but I would really like to see us implement lower-level solutions to either avoid or at least identify case-sensitivity issues

I will merge with the covidseq changes as-is then. Please open a ticket on removing whichever modules you want and we can help coordinate the distribution changes.

@labkey-jeckels
labkey-jeckels merged commit ace3b33 into develop Aug 24, 2026
8 of 9 checks passed
@labkey-jeckels
labkey-jeckels deleted the fb_removeSqlServer2 branch August 24, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants