Remove SQL Server upgrade scripts and code - #301
Conversation
|
@bbimber the interesting thing for this repo is the |
| LEFT JOIN mgap.subjectsSource ss on (t.subjectId = ss.originalId) | ||
| LEFT JOIN mgap.animalMapping am on (t.subjectId = am.subjectname) No newline at end of file | ||
| -- Matched case-insensitively so an id whose alias-table spelling differs only in case still resolves; SampleSummaryCustomizer surfaces those as subjectCaseMismatch | ||
| LEFT JOIN mgap.animalMapping am on (LOWER(t.subjectId) = LOWER(am.subjectname)) No newline at end of file |
There was a problem hiding this comment.
@labkey-jeckels - this is an example of what I'm writing about here for PRIMe/EHR: https://www.labkey.org/ONPRC/Support%20Tickets/issues-insert.view?issueDefName=siteissues
|
@labkey-jeckels: thanks for this. two points come up:
That aside, we can eliminate covidseq and probably hivrc. I'm happy to address that separate from here.
I will also think about this, but I would really like to see us implement lower-level solutions to either avoid or at least identify case-sensitivity issues |
I will merge with the covidseq changes as-is then. Please open a ticket on removing whichever modules you want and we can help coordinate the distribution changes. |
Rationale
We no longer support SQLServer as a primary DB
Changes
SupportedDatabasesinmodule.propertiesPostgresOnlyTestcovidseqschema