Skip to content

ReadXM: fix out-of-bounds reads from unvalidated dwMemPos (integer overflow) #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
e-c-hansen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ReadXM: fix out-of-bounds reads from unvalidated dwMemPos (integer overflow) #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/load_xm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,11 @@ BOOL CSoundFile::ReadXM(const BYTE *lpStream, DWORD dwMemLength)
if (dwMemPos >= dwMemLength) break;
}
}
// SECURITY: sample sizes are attacker-controlled; the loop above can
// leave dwMemPos past the end of the buffer (or wrapped). Every tail
// parser below (TEXT, MIDI, mix plugins) trusts dwMemPos, so clamp once
// here rather than guarding each site against integer overflow.
if (dwMemPos > dwMemLength) dwMemPos = dwMemLength;
// Read song comments: "TEXT"
if ((dwMemPos + 8 < dwMemLength) && (bswapLE32(*((DWORD *)(lpStream+dwMemPos))) == 0x74786574))
{
Expand Down