build(version): derive app version from git tag when package.json is a placeholder - #924
Merged
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The About box and bug report link read
__VERSIONS__.volview, which came straight frompackage.json. Sincemainpins the version to0.0.0(the release workflow stamps the real version only in the CI checkout), every non-publish build showed0.0.0.This keeps
package.jsonat0.0.0and instead falls back togit describe --tagsinvite.config.tswhen the version is the placeholder. When CI has already stamped a real version, that value still wins, so published npm tarballs are unchanged.Netlify clones shallow and without tags, so
git describehad nothing to work with (verified with a--depth 1clone: describe degrades to a bare sha). The second commit adds a tag fetch to the Netlify build command, tolerant of both shallow and complete repos, and non-fatal if the fetch fails.Resulting version shown per build:
git describe, e.g.4.4.1-152-g38d39f96With this, no release needs a version bump commit; the git tag is the single source of truth.