Skip to content

Enrollment dedup-hit log line doesn't reference the CARequestID it resolves to #7

Description

@spbsoluble

Deferred from #6 (review-findings-of-review-findings pass), flagged for triage before GA.

Where

MarkMonitorClient.EnrollCertificateAsync, the dedup-hit branch (around markmonitor-caplugin/Client/MarkMonitorClient.cs:604):

_logger.LogWarning(
    "An identical enrollment for subject {Subject} was already submitted in the last {Minutes} minute(s) - awaiting that result instead of creating a duplicate order",
    subject, RecentEnrollmentWindow.TotalMinutes);
return await existing.Tcs.Task;

Problem

This is a regression from the dedup-cache rework in #6. The log line records the subject and the
window, but not the CARequestID of the in-flight/just-completed order this call is being folded
into. When troubleshooting a "why did I only get one order for two submissions" report, there's
currently no way to correlate the dedup-hit log line with the actual order it resolved to without
also having the original enrollment's own log lines to hand.

Suggested fix

Await existing.Tcs.Task first (or thread the eventual EnrollmentResult back into the log call)
so the log line can include the resolved CARequestID.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    before-gaNeeds triage before GA releasebugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions