Set mypy to require full type annotation for all methods - #468
Open
gkreitz wants to merge 2 commits into
Open
Conversation
…cks from plastex) and require typing in mypy config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
disallow_untyped_defs = True, and adds missing type annotations. This prevents us from forgetting to add type annotations to new functions. Also setsdisallow_untyped_decorators = True, not that I expect that we'll add a ton of decorators. The settingcheck_untyped_defswas dropped, as we now require all functions to be typed.For code interacting with PlasTeX, we unfortunately end up with a ton of
Any, as I don't think we have good documentation on what types we'll be called with.One actual change in the code - in
_build_junk_modifierI made the return valueboolvia a lambda to get a cleaner type annotation. Aside from that, PR is only type annotations.