Upgrade to Go 1.27 and modernize lint/CI tooling - #54
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bump the go directive to 1.27 across all nine modules and go.work, apply range-over-int in analyzer/fallback.go, and repin golangci-lint to v2.13.2 (v2.12.2's bundled staticcheck panics under a Go 1.27 toolchain building IR for stdlib/vendor packages - reproduced independent of the go.mod bump). Also fixes a golangci-lint version drift bug: ci.yml hardcoded v2.12.2 separately from the Makefile's pin. CI now resolves both golangci-lint and the new govulncheck scan from make print-*-version, mirroring wshub's pattern. Adds govulncheck (make vuln, wired into make ci) and make tidy-check, and enables errname/nilnesserr/contextcheck/fatcontext/noctx/ durationcheck/perfsprint/makezero/wastedassign/asasalint/reassign/ copyloopvar/intrange/nolintlint in .golangci.yml, fixing what they surfaced: threaded context.Context through the CLI's DB connect/ping, swapped non-formatting fmt.Errorf/fmt.Sprintf for errors.New/concatenation, dropped stale //nolint directives, and added explained //nolint markers for deliberate container/list type assertions and sqlx.DB non-context passthroughs.
KARTIKrocks
force-pushed
the
chore/go1.27-upgrade
branch
from
September 14, 2026 11:40
0fb6cce to
36de7ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR change, and why?
Bump the go directive to 1.27 across all nine modules and go.work, apply range-over-int in analyzer/fallback.go, and repin golangci-lint to v2.13.2 (v2.12.2's bundled staticcheck panics under a Go 1.27 toolchain building IR for stdlib/vendor packages - reproduced independent of the go.mod bump).
Also fixes a golangci-lint version drift bug: ci.yml hardcoded v2.12.2 separately from the Makefile's pin. CI now resolves both golangci-lint and the new govulncheck scan from make print-*-version, mirroring wshub's pattern. Adds govulncheck (make vuln, wired into make ci) and make tidy-check, and enables errname/nilnesserr/contextcheck/fatcontext/noctx/ durationcheck/perfsprint/makezero/wastedassign/asasalint/reassign/ copyloopvar/intrange/nolintlint in .golangci.yml, fixing what they surfaced: threaded context.Context through the CLI's DB connect/ping, swapped non-formatting fmt.Errorf/fmt.Sprintf for errors.New/concatenation, dropped stale //nolint directives, and added explained //nolint markers for deliberate container/list type assertions and sqlx.DB non-context passthroughs.
Closes #
Type of change
Checklist
make cipasses (fmt-check, vet, lint, test-race) across all modulesREADME.md,AGENTS.md,.sqlguard.example.yml)## [Unreleased]inCHANGELOG.mdanalyzer/middleware/reporterResult)Notes for reviewers
Anything reviewers should focus on — tricky areas, trade-offs, follow-ups.