Extension token locking - #922
Merged
Merged
Conversation
kronosapiens
changed the title
kronosapiens
force-pushed
the
feat/extension-locking
branch
from
February 2, 2021 02:13
9b3c01f to
288ab75
Compare
kronosapiens
force-pushed
the
feat/extension-locking
branch
2 times, most recently
from
February 5, 2021 19:05
93bd554 to
d515877
Compare
Contributor
Author
|
Ah! You're so right. I think the fix here is to add a mapping of |
Contributor
Author
|
@area I don't think that's a major concern. A lot of things "cannot be trusted" because of recovery mode, but by definition it's a highly trusted mode so I'm not worried. If anything we could call it a feature -- a bug was found in an extension, we need to remove the lock so we "give" the lock to another voting contract, etc. Using recovery mode as part of an attack on a token lock seems like much more trouble than it's worth. |
kronosapiens
force-pushed
the
feat/extension-locking
branch
from
February 9, 2021 19:01
fd93293 to
e66862c
Compare
kronosapiens
force-pushed
the
feat/extension-locking
branch
from
February 9, 2021 20:23
e66862c to
671ece6
Compare
Contributor
Author
|
Definitely :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #921
Supports #915, allowing extensions (here,
VotingToken) to lock & unlock user's tokens.