fix: share MySQL character set parsing across column types and casts - #2662
Merged
manticore-projects merged 1 commit intoSep 21, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid MySQL casts and column definitions fail when they use the CHARSET abbreviation or quote the character set name. This also affects generated columns and ALTER TABLE MODIFY with ENUM types.
Route these forms through a shared ColDataType character-set production. Preserve the name's spelling and expose whether CHARSET was used; existing characterSet setters continue to render CHARACTER SET by default. CREATE TABLE, ALTER TABLE and CAST use the same path, with type equality/hashCode and AST mutation coverage.
This change addresses type character-set clauses. MySQL
CONVERT(expression, type)is a separate existing grammar gap; the existingCONVERT(expression USING charset)form is covered as a control.References: MySQL column character sets, CAST.
Validation:
checkpassed on Java 17, including grammar ambiguity, formatting, static analysis, coverage and the full test suite. JUnit XML totals: 7822 tests, 0 failures/errors, 25 skipped.