Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COPY already models table/query sources and STDIN/STDOUT, but rejects PostgreSQL's
WITH (FORMAT csv, HEADER true)option syntax. Preserve the optional WITH keyword, including PostgreSQL's accepted WITH-only legacy form, and reject empty option entries in the new WITH form and PostgreSQL dialect.Reuse CopyStatement's option representation and add a select-writer overload so query expressions reach the configured deparser. Tests cover CSV delimiters/nulls, column-list and wildcard FORCE_QUOTE, HEADER MATCH, ON_ERROR, CTE/UNION queries, AST edits, and malformed lists. Existing DuckDB tests pass. PROGRAM, WHERE, COPY data-body parsing, and DML RETURNING query sources are outside this change.
Syntax reference: PostgreSQL COPY.
Validation:
check: 7,829 XML-reported tests, 0 failures/errors, 25 skipped; formatting, grammar ambiguity, Checkstyle, PMD, and JMH compilation passed. Formatting was checked against upstream/master using a local Spotless ratchet override.