fix: support FILTER after ordered-set aggregates - #2655
Merged
manticore-projects merged 1 commit intoSep 21, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid PostgreSQL expressions such as
percentile_cont(0.5) WITHIN GROUP (ORDER BY score) FILTER (WHERE active)currently fail to parse. Accept FILTER after WITHIN GROUP and render it in that position in both AST and visitor output, while preserving ordinary aggregate/window FILTER behavior.Reuse AnalyticExpression and share filter parsing/rendering helpers. In the PostgreSQL dialect, reject the reversed FILTER-before-WITHIN-GROUP form. Tests cover ordered-set and hypothetical-set aggregates, filter/order expression visitors, malformed predicates, and window regressions.
Syntax reference: PostgreSQL aggregate expressions.
Validation:
check: 7,820 XML-reported tests, 0 failures/errors, 25 skipped; formatting, grammar ambiguity, Checkstyle, PMD, and JMH compilation passed. Formatting was checked against upstream/master using a local Spotless ratchet override.