Fix meta-modules preferred compiler bug - #2084
Open
eap wants to merge 1 commit into
Open
Conversation
eap
changed the title
eap
marked this pull request as ready for review
August 13, 2026 21:12
eap
commented
Aug 13, 2026
Comment on lines
-378
to
-379
| if not compiler.name in preferred_compiler: | ||
| continue |
Collaborator
Author
There was a problem hiding this comment.
Ditched this clause and dedented everything from here to number_of_meta_modules_written += 1
Collaborator
|
Thanks for this cleanup. I'll need to give this a thorough test on a few systems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation for this PR comes from the the function
custom_sort_keywhich was broken, leading to some bugs when generating meta-modules with compilers that were dependent on the preferred compiler.When sorting,
Spec.__contains__, checks the dependency tree of a spec, since llvm was built with gcc it got the same sort order as gcc in the list.Other fixes
The
for compiler in compilersloop had a whole bunch of meta-module logic that only applied to the preferred compiler, this was gated with a "continue" clause. I just dropped that clause and moved everything into the function context. That saved some variable scope bookkeeping and (along with the sort fixes) guarantees that it runs every time.