Fix MSVC build: rename constant identifier to avoid Windows SDK macro conflict - #3
Closed
JoseAntFer with Copilot wants to merge 2 commits into
Closed
Fix MSVC build: rename constant identifier to avoid Windows SDK macro conflict#3JoseAntFer with Copilot wants to merge 2 commits into
constant identifier to avoid Windows SDK macro conflict#3JoseAntFer with Copilot wants to merge 2 commits into
Conversation
…lict Co-authored-by: JoseAntFer <16940999+JoseAntFer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job windows-2022
Fix MSVC build: rename Aug 4, 2026
constant identifier to avoid Windows SDK macro conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows-2022 CI job was failing because
constantis defined as a macro in MSVC's Windows SDK/OpenCL headers, conflicting with its use as a parameter name and struct field in the codebase.Changes
Expressions.h/Expressions.cpp: Rename parameterdouble constant→double valindeclare_constant_float()FixedBranchSequence.h: RenameOpstruct fielddouble constant→double const_valand matching constructor parameterCompilation.cpp,FixedBranchSequence.cpp: Updateop.constant→op.const_valat all call sitesMSVC error before fix: