Skip to content

Game Crashes while breaking MeBridge if Crafting sent by it is occurring on AE2 - #831

Merged
zyxkad merged 3 commits into
IntelligenceModding:dev/0.8-1.21.1from
xTheDoctah:dev/0.8-1.21.1
Sep 2, 2026
Merged

Game Crashes while breaking MeBridge if Crafting sent by it is occurring on AE2#831
zyxkad merged 3 commits into
IntelligenceModding:dev/0.8-1.21.1from
xTheDoctah:dev/0.8-1.21.1

Conversation

@xTheDoctah

Copy link
Copy Markdown

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Bugfix

  • What is the current behavior? (You can also link to an open issue here)
    If the MeBridge is destroyed while the AE2 System is working on a crafting sent by the MeBridge, the game crashes with

java.lang.NullPointerException: Cannot invoke "appeng.api.networking.IGridNode.getGrid()" because the return value of "appeng.api.networking.crafting.ICraftingRequester.getActionableNode()" is null
	at appeng.crafting.CraftingLinkNexus.isDead(CraftingLinkNexus.java:53)
	at appeng.me.service.CraftingService.lambda$onServerEndTick$2(CraftingService.java:148)
	at java.base/java.util.Collection.removeIf(Unknown Source)
	at appeng.me.service.CraftingService.onServerEndTick(CraftingService.java:148)

This error occurs because the MeBridge didn't register itself as service

  • What is the new behavior (if this is a feature change)?
    The game simply don't crash, because .addService is added.

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    No, no changes in the matter of LUA Api

  • Other information:
    The branch used for the fix is the most updated. If the fix has to occur on another branch, tell me i will cherry-pick the commit and submit the pull with the correct branch. If you need to replicate the issue you just simply create an AE2 Crafting network and run this code onto the CC:Tweak's computer

local me = peripheral.wrap("bottom")
me.craftItem({name = "minecraft:jungle_slab", count = 300})
sleep(20)

and while the crafting is going break the MeBridge

…b linked to a crafting CPU crashes the server with: Ticking grid on end of server tick
…b linked to a crafting CPU crashes the server with: Ticking grid on end of server tick
@xTheDoctah xTheDoctah changed the title Dev/0.8 1.21.1 Game Crashes while breaking MeBridge if Crafting sent by it is occurring on AE2 Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit de79e63
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/33672849802
Jar Files AdvancedPeripherals PR 831
Expires At 2026-12-01T19:22:03Z

@zyxkad

zyxkad commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

lgtm

@zyxkad
zyxkad merged commit 7656296 into IntelligenceModding:dev/0.8-1.21.1 Sep 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants