Override deprecated transitive uuid and glob dependencies - #449
Override deprecated transitive uuid and glob dependencies#449BenjaminMichaelis with Copilot wants to merge 3 commits into
uuid and glob dependencies#449Conversation
Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>
Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>
uuid and glob dependencies
There was a problem hiding this comment.
Pull request overview
This PR adds npm overrides in the two JavaScript packages to force newer transitive versions of glob and uuid, and refreshes the lockfiles so installs resolve away from deprecated transitive dependencies.
Changes:
- Add npm
overridesin both packages to forcemocha→glob@13.0.6andnode-trx→uuid@11.1.0. - Update both
package-lock.jsonfiles to reflect the new overridden transitive dependency graph.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/microsoft-trydotnet/package.json | Adds overrides for Mocha→glob and node-trx→uuid. |
| src/microsoft-trydotnet/package-lock.json | Lockfile refresh reflecting overridden glob and uuid resolution. |
| src/microsoft-trydotnet-editor/package.json | Adds the same overrides block as the trydotnet package. |
| src/microsoft-trydotnet-editor/package-lock.json | Lockfile refresh reflecting overridden glob and uuid resolution. |
Files not reviewed (2)
- src/microsoft-trydotnet-editor/package-lock.json: Generated file
- src/microsoft-trydotnet/package-lock.json: Generated file
Suppressed comments (2)
src/microsoft-trydotnet/package.json:65
node-trx@0.9.4declaresuuidas^3.4.0(see package-lock), but this override forcesuuid@11.1.0(outside node-trx’s semver range). This is likely to break at runtime if node-trx relies on legacyuuid@3import paths/APIs. Prefer upgrading/replacingnode-trx(viamocha-trx-reporter) to a version that supports modernuuid, rather than forcing a cross-major override.
"node-trx": {
"uuid": "11.1.0"
}
src/microsoft-trydotnet-editor/package.json:67
node-trx@0.9.4declaresuuidas^3.4.0(see package-lock), but this override forcesuuid@11.1.0(outside node-trx’s semver range). This is likely to break at runtime if node-trx relies on legacyuuid@3import paths/APIs. Prefer upgrading/replacingnode-trx(viamocha-trx-reporter) to a version that supports modernuuid, rather than forcing a cross-major override.
"node-trx": {
"uuid": "11.1.0"
}
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| "mocha": { | ||
| "glob": "13.0.6" | ||
| }, |
| "mocha": { | ||
| "glob": "13.0.6" | ||
| }, |
|
@copilot Fix the code for all comments in this review thread. Do not make changes beyond what is described in the linked review thread. |
Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>
Removed the |
The JavaScript packages were still resolving deprecated transitive dependencies despite current direct dependencies:
node-trxpulleduuid@3.4.0, and Mocha pulledglob@10.5.0. This updates resolution in the affected packages without changing their direct dependency choices.Scope
/src/microsoft-trydotnet/src/microsoft-trydotnet-editorDependency resolution changes
overridessonode-trxresolvesuuidto11.1.0overridessomocharesolvesglobto13.0.6Lockfile updates
package-lock.jsonfiles to capture the new transitive dependency graphExample
{ "overrides": { "mocha": { "glob": "13.0.6" }, "node-trx": { "uuid": "11.1.0" } } }