Skip to content

Override deprecated transitive uuid and glob dependencies - #449

Open
BenjaminMichaelis with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-deprecated-packages
Open

Override deprecated transitive uuid and glob dependencies#449
BenjaminMichaelis with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-deprecated-packages

Conversation

Copilot AI commented Aug 20, 2026

Copy link
Copy Markdown

The JavaScript packages were still resolving deprecated transitive dependencies despite current direct dependencies: node-trx pulled uuid@3.4.0, and Mocha pulled glob@10.5.0. This updates resolution in the affected packages without changing their direct dependency choices.

  • Scope

    • updates /src/microsoft-trydotnet
    • updates /src/microsoft-trydotnet-editor
  • Dependency resolution changes

    • adds npm overrides so node-trx resolves uuid to 11.1.0
    • adds npm overrides so mocha resolves glob to 13.0.6
  • Lockfile updates

    • refreshes both package-lock.json files to capture the new transitive dependency graph
  • Example

    {
      "overrides": {
        "mocha": {
          "glob": "13.0.6"
        },
        "node-trx": {
          "uuid": "11.1.0"
        }
      }
    }

Copilot AI and others added 2 commits August 20, 2026 23:45
Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>
Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>
Copilot AI changed the title Fix deprecated npm dependency warnings Override deprecated transitive uuid and glob dependencies Aug 20, 2026
@BenjaminMichaelis
BenjaminMichaelis marked this pull request as ready for review August 21, 2026 00:05
Copilot AI lite review requested due to automatic review settings August 21, 2026 00:05
Copilot AI temporarily deployed to BuildAndUploadImage August 21, 2026 00:05 Inactive

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds npm overrides in the two JavaScript packages to force newer transitive versions of glob and uuid, and refreshes the lockfiles so installs resolve away from deprecated transitive dependencies.

Changes:

  • Add npm overrides in both packages to force mochaglob@13.0.6 and node-trxuuid@11.1.0.
  • Update both package-lock.json files to reflect the new overridden transitive dependency graph.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/microsoft-trydotnet/package.json Adds overrides for Mocha→glob and node-trx→uuid.
src/microsoft-trydotnet/package-lock.json Lockfile refresh reflecting overridden glob and uuid resolution.
src/microsoft-trydotnet-editor/package.json Adds the same overrides block as the trydotnet package.
src/microsoft-trydotnet-editor/package-lock.json Lockfile refresh reflecting overridden glob and uuid resolution.
Files not reviewed (2)
  • src/microsoft-trydotnet-editor/package-lock.json: Generated file
  • src/microsoft-trydotnet/package-lock.json: Generated file
Suppressed comments (2)

src/microsoft-trydotnet/package.json:65

  • node-trx@0.9.4 declares uuid as ^3.4.0 (see package-lock), but this override forces uuid@11.1.0 (outside node-trx’s semver range). This is likely to break at runtime if node-trx relies on legacy uuid@3 import paths/APIs. Prefer upgrading/replacing node-trx (via mocha-trx-reporter) to a version that supports modern uuid, rather than forcing a cross-major override.
    "node-trx": {
      "uuid": "11.1.0"
    }

src/microsoft-trydotnet-editor/package.json:67

  • node-trx@0.9.4 declares uuid as ^3.4.0 (see package-lock), but this override forces uuid@11.1.0 (outside node-trx’s semver range). This is likely to break at runtime if node-trx relies on legacy uuid@3 import paths/APIs. Prefer upgrading/replacing node-trx (via mocha-trx-reporter) to a version that supports modern uuid, rather than forcing a cross-major override.
    "node-trx": {
      "uuid": "11.1.0"
    }

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/microsoft-trydotnet/package.json Outdated
Comment on lines +60 to +62
"mocha": {
"glob": "13.0.6"
},
Comment on lines +62 to +64
"mocha": {
"glob": "13.0.6"
},
@BenjaminMichaelis

Copy link
Copy Markdown
Member

@copilot Fix the code for all comments in this review thread.

Do not make changes beyond what is described in the linked review thread.

Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>

Copilot AI commented Aug 21, 2026

Copy link
Copy Markdown
Author

@copilot Fix the code for all comments in this review thread.

Do not make changes beyond what is described in the linked re...

Removed the mocha → glob@13.0.6 override from both package.json files and refreshed the lockfiles. Since Mocha 11 only supports glob@^10.4.5, forcing a glob@13 resolution crosses a major-version boundary and risks breaking Mocha's file-discovery at runtime. The node-trx → uuid@11.1.0 override is retained as it remains valid. Committed in the latest push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants