Skip to content

Move build system to meson-python - #166

Merged
ndgrigorian merged 72 commits into
mainfrom
build-with-meson
Aug 5, 2026
Merged

Move build system to meson-python#166
ndgrigorian merged 72 commits into
mainfrom
build-with-meson

Conversation

@ndgrigorian

@ndgrigorian ndgrigorian commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

This PR proposes moving from scikit-build to meson-python as the mkl_umath build system

meson-python is already used by NumPy and eliminates the need for CMake, while also allowing setup.py to be removed (with its logic moved into the meson.build script)

Following the approach in NumPy, vendored/process_src_template.py is vendored from NumPy to be called from the build script, automating the processing of conv_template.py

This PR also adds building and testing with standard clang

Build option also changes:
The former CMake build options are now exposed as meson options and passed via -Csetup-args:
OPTIMIZATION_REPORT becomes -Csetup-args=-Dopt_report=true
MKL_THREADING becomes -Csetup-args=-Dmkl_threading=<layer>

@ndgrigorian
ndgrigorian force-pushed the build-with-meson branch 2 times, most recently from 1434bc2 to 5e8ef5a Compare March 4, 2026 11:09
@ndgrigorian
ndgrigorian force-pushed the build-with-meson branch 17 times, most recently from 5c09809 to b469c01 Compare March 5, 2026 07:29
@ndgrigorian
ndgrigorian marked this pull request as ready for review March 5, 2026 08:01
Base automatically changed from add-pre-commit to main March 5, 2026 15:29
An error occurred while trying to automatically change base from add-pre-commit to main March 5, 2026 15:29
Comment thread meson.build Outdated
Comment thread meson.build
Comment thread conda-recipe-cf/bld.bat Outdated
Comment thread conda-recipe-cf/meta.yaml

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from me. The only concern if we have to pass the benchmark job before the merge.

@vlad-perevezentsev

Copy link
Copy Markdown
Collaborator

No more comments from me. The only concern if we have to pass the benchmark job before the merge.

What about macOS support?
Should it be added as was done for mkl-service and mkl_fft fix releases?

@vchamarthi

vchamarthi commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@vlad-perevezentsev Benchmark pipeline checks now unblocked, Please check,

@ndgrigorian

Copy link
Copy Markdown
Collaborator Author

No more comments from me. The only concern if we have to pass the benchmark job before the merge.

What about macOS support? Should it be added as was done for mkl-service and mkl_fft fix releases?

After discussion, conclusion was to add OSX support. We should also add CI for the projects that uses OSX for conda builds

@antonwolfy

Copy link
Copy Markdown
Collaborator

@vlad-perevezentsev Benchmark pipeline checks now unblocked, Please check,

@vchamarthi, what is the way to verbose the benchmark results?

Comment thread meson.build
Comment thread _vendored/README.md Outdated

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vlad-perevezentsev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants