Move build system to meson-python - #166
Conversation
1434bc2 to
5e8ef5a
Compare
52b0dcf to
e73dc73
Compare
5c09809 to
b469c01
Compare
b469c01 to
787c5cb
Compare
e73dc73 to
6f05c5c
Compare
787c5cb to
ef4cb58
Compare
ef4cb58 to
72232cb
Compare
antonwolfy
left a comment
There was a problem hiding this comment.
No more comments from me. The only concern if we have to pass the benchmark job before the merge.
What about macOS support? |
|
@vlad-perevezentsev Benchmark pipeline checks now unblocked, Please check, |
After discussion, conclusion was to add OSX support. We should also add CI for the projects that uses OSX for conda builds |
@vchamarthi, what is the way to verbose the benchmark results? |
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM! Thank you @vlad-perevezentsev
This PR proposes moving from scikit-build to meson-python as the mkl_umath build system
meson-python is already used by NumPy and eliminates the need for CMake, while also allowing setup.py to be removed (with its logic moved into the meson.build script)
Following the approach in NumPy,
vendored/process_src_template.pyis vendored from NumPy to be called from the build script, automating the processing ofconv_template.pyThis PR also adds building and testing with standard clang
Build option also changes:
The former CMake build options are now exposed as meson options and passed via
-Csetup-args:OPTIMIZATION_REPORTbecomes-Csetup-args=-Dopt_report=trueMKL_THREADINGbecomes-Csetup-args=-Dmkl_threading=<layer>