feat(cambricon): add mul provider - #957
Open
baominghelly wants to merge 1 commit into
Open
Conversation
baominghelly
marked this pull request as ready for review
August 31, 2026 08:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mulwith contiguous, broadcasted, and strided tensor support.torch_mlutensor-cloning path cannot construct.Motivation
The canonical
muloperator does not currently have a native Cambricon implementation. This prevents InfiniOps from dispatching elementwise multiplication to slot 0 on Cambricon devices.Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
A targeted Cambricon
mulbuild and test were run. The repository-wide smoke subset was not run.Test Results on Supported Platforms
mulbuild and tests passedFull `pytest` output (optional)
Benchmark / Performance Impact
N/A - no performance benchmark was run.
Notes for Reviewers
kernel_utils.hhelpers.torch_mlucloning path cannot construct those tensors; those kernel dtype paths were compiled but not exercised by this pytest run.