Completed tasks 1-10 - #47
Open
Cervus23 wants to merge 2 commits into
Open
Conversation
tshemsedinov
requested changes
Nov 10, 2019
tshemsedinov
left a comment
tshemsedinov
left a comment
Member
There was a problem hiding this comment.
Run linter and tests before commit
| 'use strict'; | ||
|
|
||
| const hello = null; | ||
| const hello = (name) => { |
Member
There was a problem hiding this comment.
Suggested change
| const hello = (name) => { | |
| const hello = name => { |
| const range = null; | ||
| const range = (start, end) => { | ||
| const array = []; | ||
| for(let i = start; i <= end; i += 1) { |
Member
There was a problem hiding this comment.
Suggested change
| for(let i = start; i <= end; i += 1) { | |
| for (let i = start; i <= end; i += 1) { |
There was a problem hiding this comment.
здесь for (let i = start; i <= end; i ++) не подходит в место i++ ? вроде так же числа добавляет в массив
lsnull
reviewed
Nov 14, 2019
lsnull
left a comment
lsnull
left a comment
There was a problem hiding this comment.
const range = (start, end) => {
const array = [];
for (let i = start; i <= end; i = i+2){
array.push(i);
}
return array;
};
console.log(range(15, 30));
| console.log(`Welcome home, ${name}`); | ||
| }; | ||
|
|
||
| module.exports = { hello }; |
| const hello = (name) => { | ||
| console.log(`Welcome home, ${name}`); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Вызывать же еще нужно функцию, hello(name) ?
| const range = null; | ||
| const range = (start, end) => { | ||
| const array = []; | ||
| for(let i = start; i <= end; i += 1) { |
There was a problem hiding this comment.
здесь for (let i = start; i <= end; i ++) не подходит в место i++ ? вроде так же числа добавляет в массив
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.